Bug 150551

Summary:

Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, inspector-bugzilla-changes, ross.kirsling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Video] Bad UI behavior	none
Patch	none
Patch	none

Matt Baker

Reported 2015-10-25 21:25:01 PDT

Created attachment 264033 [details] [Video] Bad UI behavior * SUMMARY Selecting child layers with keyboard causes Compositing Reason popover to become misaligned. * STEPS TO REPRODUCE 1. Inspect page with layers (apple.com) 2. Select a node with child layer data 3. Click first child layer, popup appears correctly 4. Use up/down keys to cycle child layers => Compositing Reason popup appears next to the wrong data grid node

Attachments
[Video] Bad UI behavior (4.45 MB, video/quicktime) 2015-10-25 21:25 PDT, Matt Baker	no flags	Details
Patch (2.20 KB, patch) 2017-10-02 13:14 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (3.51 KB, patch) 2017-10-02 13:51 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-25 21:26:19 PDT

<rdar://problem/23252697>

Ross Kirsling

Comment 2 2017-10-02 13:14:30 PDT

Created attachment 322415 [details] Patch

Ross Kirsling

Comment 3 2017-10-02 13:16:58 PDT

Comment on attachment 322415 [details] Patch This patch fixes the issue for the Layers tab sidebar; let me know if you want to fix the legacy one. I liked your idea on IRC about making the API less confusing, but ultimately I suppose the lesson is "don't use the `content` setter on an existing popover unless you intend to retain the position"...

Matt Baker

Comment 4 2017-10-02 13:33:48 PDT

Comment on attachment 322415 [details] Patch r=me. If the fix is identical for the legacy sidebar, please make that change before landing.

Ross Kirsling

Comment 5 2017-10-02 13:51:04 PDT

Created attachment 322427 [details] Patch

Build Bot

Comment 6 2017-10-02 14:04:41 PDT

Comment on attachment 322427 [details] Patch Rejecting attachment 322427 [details] from review queue. ross.kirsling@sony.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.

WebKit Commit Bot

Comment 7 2017-10-02 16:55:23 PDT

Comment on attachment 322427 [details] Patch Clearing flags on attachment: 322427 Committed r222759: <http://trac.webkit.org/changeset/222759>

WebKit Commit Bot

Comment 8 2017-10-02 16:55:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.