Summary: | B3::Values that have effects should allow specification of custom HeapRanges | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 150279 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-10-24 12:41:32 PDT
Created attachment 264725 [details]
the patch
Attachment 264725 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 5 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264744 [details]
the patch
For real this time
Comment on attachment 264725 [details]
the patch
EWS is red.
Attachment 264744 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 5 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/191994 |