Bug 150535 - B3::Values that have effects should allow specification of custom HeapRanges
Summary: B3::Values that have effects should allow specification of custom HeapRanges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2015-10-24 12:41 PDT by Filip Pizlo
Modified: 2015-11-03 16:29 PST (History)
11 users (show)

See Also:

Attachments
the patch (26.25 KB, patch)
2015-11-03 14:24 PST, Filip Pizlo 		ggaren: review-
Details | Formatted Diff | Diff
the patch (26.25 KB, patch)
2015-11-03 15:53 PST, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-10-24 12:41:32 PDT 
Each memory-accessing operation has an integer range associated with it.  Two things may access the same memory if their ranges overlap.  We can also add ranges to calls and patchpoints.
Comment 1 Filip Pizlo 2015-11-03 14:24:03 PST 
Created attachment 264725 [details]
the patch
Comment 2 WebKit Commit Bot 2015-11-03 14:26:23 PST 
Attachment 264725 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-11-03 15:53:34 PST 
Created attachment 264744 [details]
the patch

For real this time
Comment 4 Geoffrey Garen 2015-11-03 15:54:17 PST 
Comment on attachment 264725 [details]
the patch

EWS is red.
Comment 5 WebKit Commit Bot 2015-11-03 15:56:30 PST 
Attachment 264744 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:78:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:80:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:117:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:119:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3ControlValue.h:133:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2015-11-03 16:29:30 PST 
Landed in http://trac.webkit.org/changeset/191994