Bug 150530

Summary:

Make the size of the benchmark canvas adaptive to the screen size and screen resolution

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Animations

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, jonlee, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	none

Said Abou-Hallawa

Reported 2015-10-23 21:43:14 PDT

We should have two choices for the benchmark canvas size: one for large screens and one for small screens. We should also count for Retina display. The canvas size should be doubled but scaled down 50%.

Attachments
Patch (74.43 KB, patch) 2015-10-30 17:31 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (703.20 KB, application/zip) 2015-10-30 18:20 PDT, Build Bot	no flags	Details
Patch (74.40 KB, patch) 2015-10-31 00:41 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-23 21:43:49 PDT

<rdar://problem/23246659>

Said Abou-Hallawa

Comment 2 2015-10-30 17:31:31 PDT

Created attachment 264448 [details] Patch

Build Bot

Comment 3 2015-10-30 18:20:05 PDT

Comment on attachment 264448 [details] Patch Attachment 264448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/360730 New failing tests: animations/multiple-backgrounds.html

Build Bot

Comment 4 2015-10-30 18:20:08 PDT

Created attachment 264454 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Said Abou-Hallawa

Comment 5 2015-10-31 00:41:49 PDT

Created attachment 264468 [details] Patch

Darin Adler

Comment 6 2015-10-31 14:47:28 PDT

Comment on attachment 264468 [details] Patch rs=me

WebKit Commit Bot

Comment 7 2015-11-01 01:27:37 PST

Comment on attachment 264468 [details] Patch Clearing flags on attachment: 264468 Committed r191853: <http://trac.webkit.org/changeset/191853>

WebKit Commit Bot

Comment 8 2015-11-01 01:27:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.