Bug 150514

Summary: Remove unnecessary details from Other Crashes section
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ap: review+, ap: commit-queue-
Updated patch none

Aakash Jain
Reported 2015-10-23 15:02:09 PDT
Please remove sections like "history", "sample" and trac link from Other Crashes as they are not relevant for other crashes (they are relevant only for tests).
Attachments
Proposed patch (3.56 KB, patch)
2015-10-23 15:08 PDT, Aakash Jain 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
Updated patch (3.52 KB, patch)
2015-10-23 16:53 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2015-10-23 15:08:38 PDT
Created attachment 263948 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2015-10-23 16:05:09 PDT
Comment on attachment 263948 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=263948&action=review I wonder if we can further simplify the json format now, getting rid of an empty dictionary. > LayoutTests/fast/harness/results.html:779 > + if (tableId == 'passes-table') { > + html += testLink(test); > + } else if (tableId == 'other-crash-tests-table') { The WebKit style is to not have braces around single-line code blocks.
Alexey Proskuryakov
Comment 3 2015-10-23 16:42:02 PDT
<rdar://problem/23235458>
Aakash Jain
Comment 4 2015-10-23 16:53:41 PDT
Created attachment 263958 [details] Updated patch Updated the style. This patch helps little bit towards ability to further simplify json, but more changes (both in javascript and webkitpy) would be required for that. I would work on that in separate patch.
WebKit Commit Bot
Comment 5 2015-10-23 17:46:50 PDT
Comment on attachment 263958 [details] Updated patch Clearing flags on attachment: 263958 Committed r191524: <http://trac.webkit.org/changeset/191524>
WebKit Commit Bot
Comment 6 2015-10-23 17:46:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.