Bug 150499

Summary: [Content Extensions] Add test for hiding content on <a ping> pings
Product: WebKit Reporter: Roopesh Chander <roop+webkit>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: achristensen, benjamin, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch with the test none

Description Roopesh Chander 2015-10-23 06:32:51 PDT
Bug https://bugs.webkit.org/show_bug.cgi?id=149873 addresses the requirement that <a ping> pings should respect content blocking rules.

However, one scenario is not handled in tests: the scenario of <a ping> pings causing some content to hide because of a 'css-display-none'. This missed scenario should also be tested.
Comment 1 Roopesh Chander 2015-10-23 06:40:58 PDT
Created attachment 263921 [details]
Patch with the test

Adding a patch with a test for ensuring that the 'css-display-none' rule works when a ping is sent from an <a ping> link. The href is a fragment (href="#id"), so that the document remains intact to be able to test that the style change is applied correctly.
Comment 2 Alex Christensen 2015-10-23 11:18:48 PDT
Comment on attachment 263921 [details]
Patch with the test

Comment 3 WebKit Commit Bot 2015-10-23 12:07:06 PDT
Comment on attachment 263921 [details]
Patch with the test

Clearing flags on attachment: 263921

Committed r191505: <http://trac.webkit.org/changeset/191505>
Comment 4 WebKit Commit Bot 2015-10-23 12:07:09 PDT
All reviewed patches have been landed.  Closing bug.