Bug 150499

Summary:

[Content Extensions] Add test for hiding content on <a ping> pings

Product:

WebKit

Reporter:

Roopesh Chander <roop+webkit>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch with the test	none

Roopesh Chander

Reported 2015-10-23 06:32:51 PDT

Bug https://bugs.webkit.org/show_bug.cgi?id=149873 addresses the requirement that <a ping> pings should respect content blocking rules. However, one scenario is not handled in tests: the scenario of <a ping> pings causing some content to hide because of a 'css-display-none'. This missed scenario should also be tested.

Attachments
Patch with the test (3.60 KB, patch) 2015-10-23 06:40 PDT, Roopesh Chander	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Roopesh Chander

Comment 1 2015-10-23 06:40:58 PDT

Created attachment 263921 [details] Patch with the test Adding a patch with a test for ensuring that the 'css-display-none' rule works when a ping is sent from an <a ping> link. The href is a fragment (href="#id"), so that the document remains intact to be able to test that the style change is applied correctly.

Alex Christensen

Comment 2 2015-10-23 11:18:48 PDT

Comment on attachment 263921 [details] Patch with the test r=me

WebKit Commit Bot

Comment 3 2015-10-23 12:07:06 PDT

Comment on attachment 263921 [details] Patch with the test Clearing flags on attachment: 263921 Committed r191505: <http://trac.webkit.org/changeset/191505>

WebKit Commit Bot

Comment 4 2015-10-23 12:07:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.