Bug 150492

Summary:

REGRESSION(r191071): Web Inspector: Can't resize split console when the window is too narrow

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	timothy: review-
Patch	timothy: review+, bburg: commit-queue-
[Image] Red - draggable area	none
Patch	none

Nikita Vasilyev

Reported 2015-10-22 23:04:24 PDT

http://trac.webkit.org/changeset/191071/trunk/Source/WebInspectorUI/UserInterface/Views/Main.css ondone Bug 147924.

Attachments
Patch (1.64 KB, patch) 2015-10-22 23:20 PDT, Nikita Vasilyev	timothy: review-	Details Formatted Diff Diff
Patch (1.37 KB, patch) 2015-10-23 15:31 PDT, Nikita Vasilyev	timothy: review+ bburg: commit-queue-	Details Formatted Diff Diff
[Image] Red - draggable area (31.35 KB, image/png) 2015-10-24 16:23 PDT, Nikita Vasilyev	no flags	Details
Patch (1.39 KB, patch) 2015-10-28 17:09 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-22 23:04:38 PDT

<rdar://problem/23231400>

Nikita Vasilyev

Comment 2 2015-10-22 23:20:10 PDT

Created attachment 263906 [details] Patch This animated GIF from bug 147924 demonstrates the problem: https://bugs.webkit.org/attachment.cgi?id=258808. (In reply to comment #0) > http://trac.webkit.org/changeset/191071/trunk/Source/WebInspectorUI/ > UserInterface/Views/Main.css ondone Bug 147924. *undone.

Timothy Hatcher

Comment 3 2015-10-23 09:16:53 PDT

Comment on attachment 263906 [details] Patch This patch is not what I think you expected.

Joseph Pecoraro

Comment 4 2015-10-23 11:22:03 PDT

I removed the pointer events because I was seeing it cause unexpected cursors for me when I was playing with the console navigation bar. Maybe when restoring it, we should see if that reproduces and if we can address it.

Nikita Vasilyev

Comment 5 2015-10-23 15:31:50 PDT

Created attachment 263950 [details] Patch (In reply to comment #3) > Comment on attachment 263906 [details] > Patch > > This patch is not what I think you expected. It is definitely not.

Timothy Hatcher

Comment 6 2015-10-23 15:58:35 PDT

Comment on attachment 263950 [details] Patch Do you see the issue Joe mentioned?

Nikita Vasilyev

Comment 7 2015-10-24 16:23:29 PDT

Created attachment 263987 [details] [Image] Red - draggable area (In reply to comment #4) > I removed the pointer events because I was seeing it cause unexpected > cursors for me when I was playing with the console navigation bar. Maybe > when restoring it, we should see if that reproduces and if we can address it. I'm not sure what you mean. I applied the patch and highlighted the draggable areas as red. Does it look fine to you?

Blaze Burg

Comment 8 2015-10-28 10:04:09 PDT

Comment on attachment 263950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263950&action=review > Source/WebInspectorUI/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). Nit: this changelog is formatted incorrectly. The Reviewed by line should always be before any description. Also, there's inconsistent tabs.

Nikita Vasilyev

Comment 9 2015-10-28 17:09:56 PDT

Created attachment 264271 [details] Patch

WebKit Commit Bot

Comment 10 2015-10-28 18:21:37 PDT

Comment on attachment 264271 [details] Patch Clearing flags on attachment: 264271 Committed r191714: <http://trac.webkit.org/changeset/191714>

WebKit Commit Bot

Comment 11 2015-10-28 18:21:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.