Bug 150474

Summary: Web Inspector: Remove generateColoredImagesForCSS and its clients
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch (Needs GTK Images Fixed)
none
Patch none

Timothy Hatcher
Reported 2015-10-22 14:11:17 PDT
We can use SVG directly, avoid the canvas bitmaps and avoid high startup costs.
Attachments
Patch (Needs GTK Images Fixed) (60.21 KB, patch)
2015-10-22 14:17 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (79.43 KB, patch)
2015-10-22 17:03 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-22 14:12:11 PDT
<rdar://problem/23224909>
Timothy Hatcher
Comment 2 2015-10-22 14:17:38 PDT
Created attachment 263864 [details] Patch (Needs GTK Images Fixed)
Joseph Pecoraro
Comment 3 2015-10-22 14:34:34 PDT
Comment on attachment 263864 [details] Patch (Needs GTK Images Fixed) View in context: https://bugs.webkit.org/attachment.cgi?id=263864&action=review r=me > Source/WebInspectorUI/UserInterface/Images/BackForwardArrows.svg:17 > + svg[id $= "-mask"] { Nit: These spaces look weird. I'm used to seeing these without spaces (e.g. input[type="search"]). > Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css:200 > .object-tree-property .read-only { > content: url(../Images/Locked.svg); > - opacity: 0.5; > > width: 8px; > height: 10px; Err, I think you can actually get rid of this entire group. I think we only show icons now for getter/setter. I don't see us setting "read-only" class on anything in ObjectTrees.
Timothy Hatcher
Comment 4 2015-10-22 17:03:27 PDT
Created attachment 263879 [details] Patch
Devin Rousso
Comment 5 2015-10-22 17:12:28 PDT
Comment on attachment 263879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263879&action=review > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css:80 > + background-image: url(../Images/DisclosureTriangles.svg#closed-normal); I did not know that you could select particular elements with "background-image: url(...)". That is crazy cool.
Joseph Pecoraro
Comment 6 2015-10-22 17:17:31 PDT
Comment on attachment 263879 [details] Patch r=me, nice getting rid of Tiny disclosure Trianges
WebKit Commit Bot
Comment 7 2015-10-22 18:11:10 PDT
Comment on attachment 263879 [details] Patch Clearing flags on attachment: 263879 Committed r191488: <http://trac.webkit.org/changeset/191488>
WebKit Commit Bot
Comment 8 2015-10-22 18:11:15 PDT
All reviewed patches have been landed. Closing bug.
Andres Gomez Garcia
Comment 9 2015-11-18 07:34:33 PST
Thanks for this patch and taking care of GTK+ icons! :)
Note You need to log in before you can comment on or make changes to this bug.