Summary: | update-webkitgtk-libs should use mesa tarball | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Salisbury <mark.salisbury> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, clopez, commit-queue, lforschler, mark.salisbury, ossy, pnormand, zan | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Mark Salisbury
2015-10-22 13:44:55 PDT
Created attachment 263870 [details]
Submitting patch for review
Just got work from Brian - he submitted https://bugs.freedesktop.org/show_bug.cgi?id=92628 to create a more public link. I don't think that needs to block making this change however. Comment on attachment 263870 [details] Submitting patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=263870&action=review Thanks. Please use prepare-ChangeLog next time, it seems you manually did it this time? > Tools/ChangeLog:9 > + https://bugs.webkit.org/show_bug.cgi?id=150470 This should be below the bug title > Tools/ChangeLog:11 > + Not reviewed yet. The OOPS line should have been kept instead of adding this one. Created attachment 263930 [details]
Proposed fix
Thanks Philippe.
Yeah - I did prepare it manually. prepare-ChangeLog doesn't find any changes:
~/git/webkit-gtk$ ./Tools/Scripts/prepare-ChangeLog
Running status to find changed, added, or removed files.
No changes found.
I'm using git. I've tried in a staged/unstaged/committed state... guess I'd need to debug it figure out what's going on.
Comment on attachment 263930 [details] Proposed fix Clearing flags on attachment: 263930 Committed r191498: <http://trac.webkit.org/changeset/191498> All reviewed patches have been landed. Closing bug. |