Bug 150428

Summary: REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, commit-queue, enrica, koivisto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Adds an API test
none
Patch for landing none

Ryosuke Niwa
Reported 2015-10-21 17:57:45 PDT
We need to avoid revealing the focused element when restoring selection during tab switches.
Attachments
Fixes the bug (16.15 KB, patch)
2015-10-21 18:10 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds an API test (24.72 KB, patch)
2015-10-22 00:23 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.86 KB, patch)
2015-10-22 03:45 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-10-21 18:10:33 PDT
Created attachment 263776 [details] Fixes the bug
Simon Fraser (smfr)
Comment 2 2015-10-21 18:18:54 PDT
Comment on attachment 263776 [details] Fixes the bug Can we make a test?
Ryosuke Niwa
Comment 3 2015-10-21 18:27:55 PDT
(In reply to comment #2) > Comment on attachment 263776 [details] > Fixes the bug > > Can we make a test? We might be able to create an WK2 API test.
Ryosuke Niwa
Comment 4 2015-10-22 00:23:22 PDT
Created attachment 263801 [details] Adds an API test
Antti Koivisto
Comment 5 2015-10-22 01:42:27 PDT
Comment on attachment 263801 [details] Adds an API test View in context: https://bugs.webkit.org/attachment.cgi?id=263801&action=review r=me > Source/WebCore/dom/Document.h:282 > +enum class RevealMode { Reveal what? SelectionRevealMode might be more informative and consistent with the other enum. > Tools/TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:44 > +TEST(WebKit2, FirstResponderScrollingPosition) Nice test!
Ryosuke Niwa
Comment 6 2015-10-22 03:45:50 PDT
Created attachment 263816 [details] Patch for landing
WebKit Commit Bot
Comment 7 2015-10-22 04:38:28 PDT
Comment on attachment 263816 [details] Patch for landing Clearing flags on attachment: 263816 Committed r191451: <http://trac.webkit.org/changeset/191451>
WebKit Commit Bot
Comment 8 2015-10-22 04:38:33 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 9 2015-10-22 17:08:04 PDT
<rdar://problem/22407558>
Note You need to log in before you can comment on or make changes to this bug.