Bug 150424

Summary: Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2015-10-21 16:56:04 PDT
Examples of this issue are in VisualStyleDetailsPanel:158 and VisualStylePropertyEditor.js:68.
Attachments
Patch (3.57 KB, patch)
2015-10-21 17:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-21 16:56:36 PDT
<rdar://problem/23211505>
Devin Rousso
Comment 2 2015-10-21 17:12:11 PDT
Created attachment 263766 [details] Patch
Devin Rousso
Comment 3 2015-10-21 17:12:35 PDT
I don't think I missed any problematic usages, but I was searching using a regex so it's possible I missed one. This is the regex I used: \.classList\.toggle\([^,\n]+,[^\)\n]+\)
WebKit Commit Bot
Comment 4 2015-10-21 17:27:11 PDT
Comment on attachment 263766 [details] Patch Clearing flags on attachment: 263766 Committed r191417: <http://trac.webkit.org/changeset/191417>
WebKit Commit Bot
Comment 5 2015-10-21 17:27:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.