Bug 150424 - Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
Summary: Web Inspector: Adjust usages of classList.toggle to ensure a true/false value...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-21 16:56 PDT by Devin Rousso
Modified: 2015-10-21 17:27 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2015-10-21 17:12 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-10-21 16:56:04 PDT 
Examples of this issue are in VisualStyleDetailsPanel:158 and VisualStylePropertyEditor.js:68.
Comment 1 Radar WebKit Bug Importer 2015-10-21 16:56:36 PDT 
<rdar://problem/23211505>
Comment 2 Devin Rousso 2015-10-21 17:12:11 PDT 
Created attachment 263766 [details]
Patch
Comment 3 Devin Rousso 2015-10-21 17:12:35 PDT 
I don't think I missed any problematic usages, but I was searching using a regex so it's possible I missed one.  This is the regex I used:
\.classList\.toggle\([^,\n]+,[^\)\n]+\)
Comment 4 WebKit Commit Bot 2015-10-21 17:27:11 PDT 
Comment on attachment 263766 [details]
Patch

Clearing flags on attachment: 263766

Committed r191417: <http://trac.webkit.org/changeset/191417>
Comment 5 WebKit Commit Bot 2015-10-21 17:27:15 PDT 
All reviewed patches have been landed.  Closing bug.