Bug 150409

Summary:

Web Inspector: srcset attributes should have hyperlinks to the resources

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

URL:

https://www.webkit.org/blog/3574/web-inspector-interface-changes/

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[IMAGE] CodeMirror test case	none
[IMAGE] DOMTree test case	none
[PATCH] Follow-up Fixes for Multiline	none

Timothy Hatcher

Reported 2015-10-21 12:51:01 PDT

We link src and href, but we don't link the URLs inside srcset. <img src="/blog-files/inspector-tab-bar.png" srcset="/blog-files/inspector-tab-bar.png 1x, /blog-files/inspector-tab-bar-2x.png 2x" alt="Web Inspector Tab Bar" width="1221" height="208"> This will require multiple links in an attribute, unlike src and href. We will need to parse the srcset microsyntax.

Attachments
[PATCH] Proposed Fix (8.26 KB, patch) 2015-10-21 16:56 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] CodeMirror test case (366.18 KB, image/png) 2015-10-21 16:57 PDT, Joseph Pecoraro	no flags	Details
[IMAGE] DOMTree test case (381.81 KB, image/png) 2015-10-21 16:57 PDT, Joseph Pecoraro	no flags	Details
[PATCH] Follow-up Fixes for Multiline (3.52 KB, patch) 2015-10-22 11:47 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-21 12:51:21 PDT

<rdar://problem/23206394>

Joseph Pecoraro

Comment 2 2015-10-21 16:01:55 PDT

This affects both (1) CodeMirror content and (2) DOMTree content.

Joseph Pecoraro

Comment 3 2015-10-21 16:56:47 PDT

Created attachment 263762 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 4 2015-10-21 16:57:08 PDT

Created attachment 263763 [details] [IMAGE] CodeMirror test case

Joseph Pecoraro

Comment 5 2015-10-21 16:57:30 PDT

Created attachment 263764 [details] [IMAGE] DOMTree test case

WebKit Commit Bot

Comment 6 2015-10-21 17:51:07 PDT

Comment on attachment 263762 [details] [PATCH] Proposed Fix Clearing flags on attachment: 263762 Committed r191421: <http://trac.webkit.org/changeset/191421>

WebKit Commit Bot

Comment 7 2015-10-21 17:51:11 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 8 2015-10-22 11:44:22 PDT

I missed a `git add` for the better multi-line attribute handling. Reopening and adding a follow-up fixes patch.

Joseph Pecoraro

Comment 9 2015-10-22 11:47:24 PDT

Created attachment 263841 [details] [PATCH] Follow-up Fixes for Multiline

Timothy Hatcher

Comment 10 2015-10-22 13:05:48 PDT

Image generators and vars are also supported. The following is from Web Inspector: background-image: -webkit-canvas(foo); background-image: linear-gradient(to bottom, hsl(0, 0%, 78%), hsl(0, 0%, 85%)); Yes, var would be a larger undertaking. Likely you would provide a menu selector for available variables.

WebKit Commit Bot

Comment 11 2015-10-22 13:48:49 PDT

Comment on attachment 263841 [details] [PATCH] Follow-up Fixes for Multiline Rejecting attachment 263841 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: b) 8 0x00007fff88a2628d _dispatch_client_callout (in libdispatch.dylib) 9 0x00007fff88a28673 _dispatch_queue_drain (in libdispatch.dylib) 10 0x00007fff88a299c1 _dispatch_queue_invoke (in libdispatch.dylib) 11 0x00007fff88a27f87 _dispatch_root_queue_drain (in libdispatch.dylib) 12 0x00007fff88a29177 _dispatch_worker_thread2 (in libdispatch.dylib) 13 0x00007fff8db69ef8 _pthread_wqthread (in libsystem_pthread.dylib) 14 0x00007fff8db6cfb9 start_wqthread (in libsystem_pthread.dylib) Full output: http://webkit-queues.webkit.org/results/322872

WebKit Commit Bot

Comment 12 2015-10-22 14:37:47 PDT

Comment on attachment 263841 [details] [PATCH] Follow-up Fixes for Multiline Clearing flags on attachment: 263841 Committed r191478: <http://trac.webkit.org/changeset/191478>

WebKit Commit Bot

Comment 13 2015-10-22 14:37:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.