Bug 150407

Summary: run-webkit-tests does not copy all crash logs for layout test failures on Mac
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, dburkart, ddkilzer, glenn, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=150056
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2015-10-21 12:35:49 PDT
Mac specific implementation for https://bugs.webkit.org/show_bug.cgi?id=150056
Attachments
Proposed patch (2.63 KB, patch)
2015-10-21 12:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2015-10-21 12:46:44 PDT
Created attachment 263715 [details] Proposed patch
Aakash Jain
Comment 2 2015-10-21 12:49:28 PDT
This patch is similar to the iOS specific portion of patch for https://bugs.webkit.org/show_bug.cgi?id=150056
Alexey Proskuryakov
Comment 3 2015-10-21 15:17:14 PDT
Comment on attachment 263715 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=263715&action=review > Tools/Scripts/webkitpy/port/mac.py:223 > + def _merge_crash_logs(self, logs, new_logs, crashed_processes): It would be good to avoid copy/pasting this code, as it appears to be the same on iOS.
WebKit Commit Bot
Comment 4 2015-10-21 16:06:35 PDT
Comment on attachment 263715 [details] Proposed patch Clearing flags on attachment: 263715 Committed r191410: <http://trac.webkit.org/changeset/191410>
WebKit Commit Bot
Comment 5 2015-10-21 16:06:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.