Bug 150404

Summary: Web Inspector: Array previews with Symbol objects have too few preview values
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-10-21 12:00:42 PDT
* SUMMARY Array previews with Symbol objects have too few preview values * STEPS TO REPRODUCE 1. js> [Symbol(), 1, 2, 3, 4] => [Symbol()], expected [Symbol(), 1, 2, 3, 4]
Attachments
[PATCH] Proposed Fix (1.32 KB, patch)
2015-10-21 12:08 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-10-21 12:01:14 PDT
I think I see what is wrong. _generatePreview has a `return` instead of a `continue` in a loop when handling Symbol values.
Joseph Pecoraro
Comment 2 2015-10-21 12:08:36 PDT
Created attachment 263709 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2015-10-21 12:57:32 PDT
Comment on attachment 263709 [details] [PATCH] Proposed Fix Clearing flags on attachment: 263709 Committed r191397: <http://trac.webkit.org/changeset/191397>
WebKit Commit Bot
Comment 4 2015-10-21 12:57:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.