Bug 150397

Summary:

Un-expose obsolete HTMLBaseFontElement

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cgarcia, commit-queue, darin, ossy, rniwa

Priority:

Keywords:

WebExposed

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

URL:

https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch	none

Chris Dumez

Reported 2015-10-21 10:39:45 PDT

Un-expose legacy HTMLBaseFontElement: https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features Firefox and Chrome currently do not expose HTMLBaseFontElement on the global Window object. Also, document.createElement("basefont") constructs a generic HTMLElement.

Attachments
Patch (72.72 KB, patch) 2015-10-21 10:48 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (73.33 KB, patch) 2015-10-21 11:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (99.50 KB, patch) 2015-10-21 13:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (651.56 KB, application/zip) 2015-10-21 13:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (677.17 KB, application/zip) 2015-10-21 13:58 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (785.95 KB, application/zip) 2015-10-21 14:08 PDT, Build Bot	no flags	Details
Patch (93.06 KB, patch) 2015-10-21 14:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (828.53 KB, application/zip) 2015-10-21 15:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (881.84 KB, application/zip) 2015-10-21 15:22 PDT, Build Bot	no flags	Details
Patch (94.22 KB, patch) 2015-10-21 15:39 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2015-10-21 10:48:38 PDT

Created attachment 263700 [details] Patch

Chris Dumez

Comment 2 2015-10-21 11:02:00 PDT

Created attachment 263703 [details] Patch

Chris Dumez

Comment 3 2015-10-21 13:10:18 PDT

Created attachment 263721 [details] Patch

Build Bot

Comment 4 2015-10-21 13:54:44 PDT

Comment on attachment 263721 [details] Patch Attachment 263721 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/317277 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

Build Bot

Comment 5 2015-10-21 13:54:48 PDT

Created attachment 263728 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 6 2015-10-21 13:58:50 PDT

Comment on attachment 263721 [details] Patch Attachment 263721 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/317283 New failing tests: http/tests/security/cross-frame-access-put.html

Build Bot

Comment 7 2015-10-21 13:58:54 PDT

Created attachment 263730 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 8 2015-10-21 14:08:31 PDT

Comment on attachment 263721 [details] Patch Attachment 263721 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/317288 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

Build Bot

Comment 9 2015-10-21 14:08:35 PDT

Created attachment 263731 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 10 2015-10-21 14:23:03 PDT

Created attachment 263738 [details] Patch

Build Bot

Comment 11 2015-10-21 15:15:00 PDT

Comment on attachment 263738 [details] Patch Attachment 263738 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/317634 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html

Build Bot

Comment 12 2015-10-21 15:15:04 PDT

Created attachment 263745 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 13 2015-10-21 15:22:22 PDT

Comment on attachment 263738 [details] Patch Attachment 263738 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/317673 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html

Build Bot

Comment 14 2015-10-21 15:22:26 PDT

Created attachment 263748 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Chris Dumez

Comment 15 2015-10-21 15:39:03 PDT

Created attachment 263750 [details] Patch

Ryosuke Niwa

Comment 16 2015-10-21 17:09:28 PDT

Isn't this change risky in terms of backwards compatibility?

WebKit Commit Bot

Comment 17 2015-10-21 17:59:07 PDT

Comment on attachment 263750 [details] Patch Clearing flags on attachment: 263750 Committed r191423: <http://trac.webkit.org/changeset/191423>

WebKit Commit Bot

Comment 18 2015-10-21 17:59:13 PDT

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 19 2015-10-21 22:51:26 PDT

http://trac.webkit.org/changeset/191438 should fix the clean build after this.

Csaba Osztrogonác

Comment 20 2015-10-22 02:32:28 PDT

Just to document, https://trac.webkit.org/changeset/191448 fixed the GTK build.

Chris Dumez

Comment 21 2015-10-22 09:21:04 PDT

Thanks for the follow-up build fixes.

Chris Dumez

Comment 22 2015-10-22 09:23:45 PDT

(In reply to comment #16) > Isn't this change risky in terms of backwards compatibility? Well, this is a very old feature that has never really been fully cross-browser. Also, Firefox and Chrome do not support this so I think the risk is low. The only possible breakage would be for Safari-only sites that rely on this "ancient" feature.

Note You need to log in before you can comment on or make changes to this bug.