Bug 150396

Summary: check-webkit-style complains about missing operator whitespace inside character literal
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: Tools / TestsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, lforschler, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150394, 150451    
Attachments:
Description Flags
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2015-10-21 10:09:57 PDT
Bug 150394, contains a patch that loads the OS/2 table as follows: CFDataRef os2Table = CGFontCopyTableForTag(m_platformData.cgFont(), 'OS/2') Here 'OS/2' is a character literal (32 bit integer) used as a tag representing the TrueType table. The slash is not used as an operator, however check-webkit-style complains with the following message: ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:179: Missing spaces around / [whitespace/operators] [3]
Attachments
Patch (2.70 KB, patch)
2015-10-24 08:52 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2015-10-24 08:52:58 PDT
Created attachment 263979 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2015-10-24 08:56:24 PDT
Note that the 'OS/2' case is already in the source code: https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm#L284
Csaba Osztrogonác
Comment 3 2015-10-24 12:21:04 PDT
Comment on attachment 263979 [details] Patch Could you please add a new unittest covers this change?
Csaba Osztrogonác
Comment 4 2015-10-24 12:22:03 PDT
(In reply to comment #3) > Comment on attachment 263979 [details] > Patch > > Could you please add a new unittest covers this change? Sorry, please ignore this comment.
Frédéric Wang (:fredw)
Comment 5 2015-10-24 16:37:07 PDT
Committed r191538: <http://trac.webkit.org/changeset/191538>
Note You need to log in before you can comment on or make changes to this bug.