Summary: | check-webkit-style complains about missing operator whitespace inside character literal | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||
Component: | Tools / Tests | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, glenn, lforschler, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 150394, 150451 | ||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2015-10-21 10:09:57 PDT
Created attachment 263979 [details]
Patch
Note that the 'OS/2' case is already in the source code: https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm#L284 Comment on attachment 263979 [details]
Patch
Could you please add a new unittest covers this change?
(In reply to comment #3) > Comment on attachment 263979 [details] > Patch > > Could you please add a new unittest covers this change? Sorry, please ignore this comment. Committed r191538: <http://trac.webkit.org/changeset/191538> |