| Summary: | Make table collapsed borders subpixel aware. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, nvasilyev, simon.fraser, webkit | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 150410, 154437 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2015-10-20 20:30:08 PDT
*** Bug 154435 has been marked as a duplicate of this bug. *** I think this is a duplicate. *** This bug has been marked as a duplicate of bug 154980 *** This is not yet fixed. Making collapsed borders work is a bit more than device pixel snapping at paint time (re bug 154980) I see. Thanks for the clarification. (In reply to comment #4) > I see. Thanks for the clarification. np. I should have landed the patch for this first and not for bug 154980, but I thought I could make collapsed borders painting work for the generic cases without doing this first, but apparently I even regressed some cases. Will upload a patch soon. Created attachment 273086 [details]
Patch
(In reply to comment #4) > I see. Thanks for the clarification. Here is the WIP patch. -I need to add some test cases. Created attachment 273099 [details]
Patch
Comment on attachment 273099 [details] Patch Attachment 273099 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/928522 New failing tests: fast/custom-elements/HTMLElement-constructor.html Created attachment 273105 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #9) > Comment on attachment 273099 [details] > Patch > > Attachment 273099 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/928522 > > New failing tests: > fast/custom-elements/HTMLElement-constructor.html I don't believe you EWS! Created attachment 273112 [details]
Patch
Comment on attachment 273112 [details] Patch Clearing flags on attachment: 273112 Committed r197627: <http://trac.webkit.org/changeset/197627> All reviewed patches have been landed. Closing bug. Could you please update iOS test results? https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197639%20(3694)/results.html I now see that you updated many results already; there are still two or three remaining failures. (In reply to comment #16) > I now see that you updated many results already; there are still two or > three remaining failures. I got a bit confused by these failures. It just occurred to me that we are always in hidpi mode on iOS. |