Bug 150382

Summary: Single tapping clickable elements in unscalable pages should show a tap highlight
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 149968    
Bug Blocks:    
Attachments:
Description Flags
Patch simon.fraser: review+

Description Wenson Hsieh 2015-10-20 18:48:07 PDT
Single tapping clickable elements in unscalable pages should show a tap highlight. Currently, tap highlights are broken for fast clicking in pages that are unscalable because WKContentView assumes that the tap highlight geometry will arrive from the web process before the single tap is committed by the gesture recognizer. However, when the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is committed before the geometries come in.
Comment 1 Wenson Hsieh 2015-10-20 18:50:02 PDT
<rdar://problem/23172720>
Comment 2 Wenson Hsieh 2015-10-21 14:14:32 PDT
Created attachment 263733 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-10-21 14:58:12 PDT
Comment on attachment 263733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254
> +    _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled];

dot syntax?
Comment 4 Wenson Hsieh 2015-10-21 15:29:19 PDT
Comment on attachment 263733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254
>> +    _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled];
> 
> dot syntax?

Fixed!
Comment 5 Wenson Hsieh 2015-10-21 15:31:39 PDT
Committed r191409: <http://trac.webkit.org/changeset/191409>