Bug 150377

Summary: HTMLIFrameElement.sandbox should be a DOMSettableTokenList
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ggaren, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/embedded-content.html#htmliframeelement
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-10-20 16:22:52 PDT
HTMLIframeElement.sandbox should be a DOMSettableTokenList as per the HTML specification: https://html.spec.whatwg.org/multipage/embedded-content.html#htmliframeelement Chrome and Firefox match the specification but Safari/WebKit uses a DOMString.
Attachments
Patch (10.25 KB, patch)
2015-10-20 20:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.20 KB, patch)
2015-10-21 09:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-10-20 20:40:02 PDT
Created attachment 263655 [details] Patch
Ryosuke Niwa
Comment 2 2015-10-21 03:51:18 PDT
Comment on attachment 263655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263655&action=review > Source/WebCore/html/HTMLIFrameElement.idl:34 > + #endif #endif shouldn't be indented. > LayoutTests/fast/frames/sandbox-attribute.html:11 > +// Test Sanitization. I don't think we need this comment.
Chris Dumez
Comment 3 2015-10-21 09:15:16 PDT
Created attachment 263682 [details] Patch
WebKit Commit Bot
Comment 4 2015-10-21 10:01:00 PDT
Comment on attachment 263682 [details] Patch Clearing flags on attachment: 263682 Committed r191388: <http://trac.webkit.org/changeset/191388>
WebKit Commit Bot
Comment 5 2015-10-21 10:01:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.