Bug 150366

Summary:

AX: Expose table size and cell indexes on iOS

Product:

WebKit

Reporter:

Nan Wang <n_wang>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	none

Nan Wang

Reported 2015-10-20 10:15:25 PDT

Expose table row/column counts and ARIA 1.1 table related attributes on iOS.

Attachments
patch (23.42 KB, patch) 2015-10-20 13:01 PDT, Nan Wang	no flags	Details Formatted Diff Diff
patch (23.44 KB, patch) 2015-10-20 23:12 PDT, Nan Wang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-20 10:15:42 PDT

<rdar://problem/23185254>

Nan Wang

Comment 2 2015-10-20 13:01:00 PDT

Created attachment 263604 [details] patch

chris fleizach

Comment 3 2015-10-20 16:15:59 PDT

Comment on attachment 263604 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review I'm wondering > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921 > + for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject()) why the change here > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012 > + return rowCount > 0 ? rowCount : 0; can we write as return table->rowCount() > 0 ? : 0; > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1024 > + return colCount > 0 ? colCount : 0; ditto > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1036 > + return rowCount > 0 ? rowCount : 0; ditto > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1048 > + return colCount > 0 ? colCount : 0; ditto

Nan Wang

Comment 4 2015-10-20 16:44:56 PDT

Comment on attachment 263604 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921 >> + for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject()) > > why the change here in isDataTable(), it returns false when the element has ARIA role. So aria table will be considered as not a table. >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012 >> + return rowCount > 0 ? rowCount : 0; > > can we write as > > return table->rowCount() > 0 ? : 0; Ok.

chris fleizach

Comment 5 2015-10-20 16:49:58 PDT

Comment on attachment 263604 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review >>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921 >>> + for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject()) >> >> why the change here > > in isDataTable(), it returns false when the element has ARIA role. So aria table will be considered as not a table. in that case we might want isExposableThroughAccessibility()

Nan Wang

Comment 6 2015-10-20 23:12:10 PDT

Created attachment 263662 [details] patch I think "table->ariaRowCount() > 0 ? : 0" is equivalent to "table->ariaRowCount > 0 ? table->ariaRowCount > 0 : 0", which is not what we want: "table->ariaRowCount > 0 : table->ariaRowCount : 0". So I didn't change those.

WebKit Commit Bot

Comment 7 2015-10-21 10:47:22 PDT

Comment on attachment 263662 [details] patch Clearing flags on attachment: 263662 Committed r191391: <http://trac.webkit.org/changeset/191391>

WebKit Commit Bot

Comment 8 2015-10-21 10:47:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.