Bug 150345

Summary: Remove unused support for long presses from WebKit
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, ryanhaddad, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Description Tim Horton 2015-10-19 16:23:54 PDT
Remove unused support for long presses from WebKit
Comment 1 Tim Horton 2015-10-19 16:24:10 PDT
Created attachment 263524 [details]
Patch
Comment 2 Tim Horton 2015-10-19 17:18:13 PDT
http://trac.webkit.org/changeset/191323
Comment 3 Ryan Haddad 2015-10-19 18:31:32 PDT
It looks like this change may have broken some builds:

/Volumes/Data/slave/elcapitan-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:1750:10: error: no member named 'setLongMousePressEnabled' in 'WebCore::InternalSettingsGenerated'

Mac builds:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20%28Build%29/builds/563
https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20%28Build%29/builds/9578
https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/21019

iOS builds:
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/532
https://build.webkit.org/builders/Apple%20iOS%209%20Release%20%28Build%29/builds/435
Comment 4 Ryan Haddad 2015-10-19 18:32:57 PDT
May just need a clean build.
Comment 5 Tim Horton 2015-10-19 18:49:05 PDT
Needs a clean build or some Makefiles to finally be fixed.