Bug 150302

Summary: Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with ENABLE_CONTENT_EXTENSIONS=OFF
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit Misc.Assignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sungmann Cho
Reported 2015-10-18 07:05:46 PDT
Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with CONTENT_EXTENSIONS=OFF.
Attachments
Patch (1.74 KB, patch)
2015-10-18 07:09 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2015-10-18 07:58 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-10-18 07:09:28 PDT
Created attachment 263420 [details] Patch
Sungmann Cho
Comment 2 2015-10-18 07:58:32 PDT
Created attachment 263421 [details] Patch
WebKit Commit Bot
Comment 3 2015-10-18 16:37:20 PDT
Comment on attachment 263421 [details] Patch Clearing flags on attachment: 263421 Committed r191266: <http://trac.webkit.org/changeset/191266>
WebKit Commit Bot
Comment 4 2015-10-18 16:37:24 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2015-10-19 00:49:11 PDT
(In reply to comment #3) > Comment on attachment 263421 [details] > Patch > > Clearing flags on attachment: 263421 > > Committed r191266: <http://trac.webkit.org/changeset/191266> Why did you need this change? ContentExtensionActions.h is properly guarded with ENABLE(CONTENT_EXTENSIONS. https://trac.webkit.org/browser/trunk/Source/WebCore/contentextensions/ContentExtensionActions.h It's not common to use guards for include statements.
Sungmann Cho
Comment 6 2015-10-19 06:34:30 PDT
> Why did you need this change? ContentExtensionActions.h > is properly guarded with ENABLE(CONTENT_EXTENSIONS. Because I got errors "cannot include ContentExtensionActions.h" while building on Visual Studio with ENABLE_CONTENT_EXTENSION=OFF (this is the default value in the AppleWin target). Honestly, I don't know exactly why the errors occur. I just simply followed other cases like ContentExtensionRule.h. But today I realized through webkit.org/b/150300 that our Visual Studio projects are not being managed well, so I think the root cause of the problem might be elsewhere. > It's not common to use guards for include statements. I agree with your point, but I can find so many cases like this in our codebase. How do I understand this?
Note You need to log in before you can comment on or make changes to this bug.