Summary: | Enhance TextStream for logging, remove subclasses, log more things | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mmaxfield, sam, simon.fraser, thorton | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-10-16 22:35:11 PDT
Created attachment 263359 [details]
Patch
Created attachment 263361 [details]
Patch
Comment on attachment 263361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263361&action=review LGTM, but i'll wait for thorton to r+ it. > Source/WebCore/ChangeLog:58 > + * platform/graphics/ca/PlatformCAAnimation.cpp: Added. Why did you make a new file for this? > Source/WebCore/CMakeLists.txt:2142 > + platform/animation/TimingFunction.cpp Shouldn't there be additions for the new header files? > Source/WebCore/platform/animation/TimingFunction.cpp:1 > +/* Why did you make a new file for this? (In reply to comment #3) > Comment on attachment 263361 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263361&action=review > > LGTM, but i'll wait for thorton to r+ it. > > > Source/WebCore/ChangeLog:58 > > + * platform/graphics/ca/PlatformCAAnimation.cpp: Added. > > Why did you make a new file for this? Because there was only the .h file, and I don't want PlatformCAAnimation.h pulling in TextStream.h. > > Source/WebCore/CMakeLists.txt:2142 > > + platform/animation/TimingFunction.cpp > > Shouldn't there be additions for the new header files? Header files are existing. > > Source/WebCore/platform/animation/TimingFunction.cpp:1 > > +/* > > Why did you make a new file for this? Ditto. |