Bug 150239

Summary: Move all the probe trampolines into their respective MacroAssembler files.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. saam: review+

Mark Lam
Reported 2015-10-16 10:41:01 PDT
With this, we can get rid of all the JITStubs<CPU>.cpp files. There is one exception: JITStubsMSVC64.asm. That one is unrelated to the probe mechanism. So, I'll leave it as is.
Attachments
the patch. (224.31 KB, patch)
2015-10-16 11:32 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-10-16 11:32:50 PDT
Created attachment 263299 [details] the patch.
WebKit Commit Bot
Comment 2 2015-10-16 11:34:55 PDT
Attachment 263299 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp:309: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp:491: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp:454: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARMv7.cpp:321: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:348: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2015-10-16 12:02:16 PDT
Comment on attachment 263299 [details] the patch. LGTM
Mark Lam
Comment 4 2015-10-16 12:12:27 PDT
Thanks. Landed in r191191: <http://trac.webkit.org/r191191>.
Note You need to log in before you can comment on or make changes to this bug.