Bug 150238 – Finalize bug 149952 patch

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[youenn fablet]

Following on bug 149952, we should fix what Darin mentionned:

> Source/WebCore/bindings/js/JSDOMConstructor.h:32
> +    static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue);

I noticed one tiny mistake that we should return and fix. I don’t think the meaning of JSC::JSValue is clear here without the argument name, prototype.

> Source/WebCore/bindings/js/JSDOMConstructor.h:137
> +template<typename JSClass> void JSDOMConstructor<JSClass>::finishCreation(JSC::VM& vm, JSDOMGlobalObject& globalObject)

In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.

> Source/WebCore/bindings/js/JSDOMConstructor.h:144
> +template<typename JSClass> JSC::ConstructType JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData& constructData)

In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.

[youenn fablet]

Created attachment 263283 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263283 [details]
Patch

Clearing flags on attachment: 263283

Committed r191238: <http://trac.webkit.org/changeset/191238>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.