Bug 150237

Summary:

Computed style should work correctly with slotted elements that have display:none

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarcelo, commit-queue, esprehn+autocc, kangil.han, rniwa, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

150263

Bug Blocks:

148695

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
patch	none
patch	none

Antti Koivisto

Reported 2015-10-16 10:14:25 PDT

If an element has display:none we don't normally retain or even compute its style (as it is not rendered). If getComputedStyle is invoked for such element we resolve the style (along with any ancestors) and cache it separately to rare data. This path needs to work with slotted elements in shadow trees.

Attachments
patch (16.41 KB, patch) 2015-10-16 11:15 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (693.75 KB, application/zip) 2015-10-16 11:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (1018.48 KB, application/zip) 2015-10-16 11:54 PDT, Build Bot	no flags	Details
patch (17.81 KB, patch) 2015-10-16 12:06 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (18.86 KB, patch) 2015-10-18 14:42 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2015-10-16 11:15:48 PDT

Created attachment 263296 [details] patch

Build Bot

Comment 2 2015-10-16 11:53:10 PDT

Comment on attachment 263296 [details] patch Attachment 263296 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/296425 New failing tests: editing/style/apply-style-atomic.html

Build Bot

Comment 3 2015-10-16 11:53:14 PDT

Created attachment 263302 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-10-16 11:54:48 PDT

Comment on attachment 263296 [details] patch Attachment 263296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/296412 New failing tests: editing/style/apply-style-atomic.html

Build Bot

Comment 5 2015-10-16 11:54:51 PDT

Created attachment 263303 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Antti Koivisto

Comment 6 2015-10-16 12:06:07 PDT

Created attachment 263304 [details] patch

Andreas Kling

Comment 7 2015-10-16 12:13:55 PDT

Comment on attachment 263304 [details] patch r=me

WebKit Commit Bot

Comment 8 2015-10-16 13:51:00 PDT

Comment on attachment 263304 [details] patch Clearing flags on attachment: 263304 Committed r191204: <http://trac.webkit.org/changeset/191204>

WebKit Commit Bot

Comment 9 2015-10-16 13:51:05 PDT

All reviewed patches have been landed. Closing bug.