Bug 150219

Summary: Hook up autolayout intrinsic sizing for WKWebView
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2015-10-15 19:35:18 PDT
Hook up autolayout intrinsic sizing for WKWebView
Attachments
Patch (21.56 KB, patch)
2015-10-15 19:39 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (21.31 KB, patch)
2015-10-15 19:43 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (21.45 KB, patch)
2015-10-16 10:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (21.46 KB, patch)
2015-10-16 10:24 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (21.48 KB, patch)
2015-10-16 10:28 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-10-15 19:39:30 PDT
Created attachment 263238 [details] Patch
Tim Horton
Comment 2 2015-10-15 19:43:08 PDT
Created attachment 263239 [details] Patch
Tim Horton
Comment 3 2015-10-16 10:05:13 PDT
Created attachment 263280 [details] Patch
Tim Horton
Comment 4 2015-10-16 10:06:11 PDT
Comment on attachment 263280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263280&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:719 > + intrinsicContentSizeAcknowledgingFlexibleWidth.width = NSViewNoInstrinsicMetric; This one needs to be noIntrinsicMetric too.
Tim Horton
Comment 5 2015-10-16 10:24:57 PDT
Created attachment 263285 [details] Patch
Anders Carlsson
Comment 6 2015-10-16 10:26:16 PDT
Comment on attachment 263285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263285&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:189 > +@property (nonatomic, setter=_setMinimumLayoutWidth:) CGFloat _minimumLayoutWidth; Needs WK_AVAILABLE
Tim Horton
Comment 7 2015-10-16 10:28:38 PDT
Created attachment 263286 [details] Patch
Tim Horton
Comment 8 2015-10-16 10:31:29 PDT
http://trac.webkit.org/changeset/191183
Note You need to log in before you can comment on or make changes to this bug.