Bug 150152

Summary:

[iOS] build-dumprendertree does not build ImageDiff

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

Tools / Tests

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dbates, ddkilzer, lforschler, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

All

Attachments:

Description	Flags
Patch	thorton: review+

Andy Estes

Reported 2015-10-14 17:46:10 PDT

[iOS] build-dumprendertree does not build ImageDiff

Attachments
Patch (1.97 KB, patch) 2015-10-14 17:53 PDT, Andy Estes	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2015-10-14 17:53:33 PDT

Created attachment 263125 [details] Patch

Andy Estes

Comment 2 2015-10-14 17:58:16 PDT

Committed r191078: <http://trac.webkit.org/changeset/191078>

Alexey Proskuryakov

Comment 3 2015-10-14 20:26:13 PDT

Does this mean that we will be building ImageDiff for iOS (simulator) instead of the host OS? I do not fully understand the setup yet, but this sounds wrong. One thing that's built for the host is LayoutTestRelay.

Andy Estes

Comment 4 2015-10-14 20:57:25 PDT

We have always(In reply to comment #3) > Does this mean that we will be building ImageDiff for iOS (simulator) > instead of the host OS? I do not fully understand the setup yet, but this > sounds wrong. I don't know if it's right, but we do build ImageDiff for iOS Simulator and run it in the sim bootstrap (see http://trac.webkit.org/changeset/172118). This just brings build-dumprendertree in line with what is built by make and the 'All Tools' scheme.

Note You need to log in before you can comment on or make changes to this bug.