Bug 150127

Summary: Rename some JSC option names to be more uniform.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. ggaren: review+

Mark Lam
Reported 2015-10-14 10:52:10 PDT
Will rename JSC_enableXXX options to JSC_useXXX, and JSC_showXXX options to JSC_dumpXXX. Also will rename a few other miscellaneous to options, to abide by this scheme. Also will rename some functions to match the option names where relevant.
Attachments
the patch. (75.68 KB, patch)
2015-10-14 11:08 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-10-14 11:08:48 PDT
Created attachment 263088 [details] the patch.
WebKit Commit Bot
Comment 2 2015-10-14 11:12:03 PDT
Attachment 263088 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:328: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:331: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:350: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:353: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-10-14 11:53:55 PDT
Comment on attachment 263088 [details] the patch. r=me
Mark Lam
Comment 4 2015-10-14 11:58:23 PDT
Thanks. Landed in r191058: <http://trac.webkit.org/r191058>.
Note You need to log in before you can comment on or make changes to this bug.