Bug 150126

Summary: [WIN] Layout Test fast/dynamic/insert-before-table-part-in-continuation.html is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryan Haddad
Reported 2015-10-14 10:49:53 PDT
The following layout test is failing on Windows and GTK after http://trac.webkit.org/changeset/191011 fast/dynamic/insert-before-table-part-in-continuation.html
Attachments
Patch (1.45 KB, patch)
2015-10-19 10:51 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (21.60 KB, patch)
2015-10-19 11:06 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2015-10-20 13:00 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 2 2015-10-19 10:51:40 PDT
Created attachment 263490 [details] Patch Marking test as flaky on win
alan
Comment 3 2015-10-19 11:01:31 PDT
Comment on attachment 263490 [details] Patch It needs rebaselining on Win (r191011 has the updated expected result only for mac)
Ryan Haddad
Comment 4 2015-10-19 11:06:54 PDT
Created attachment 263492 [details] Patch Here is a patch with an updated expectation file for win.
WebKit Commit Bot
Comment 5 2015-10-19 12:12:26 PDT
Comment on attachment 263492 [details] Patch Clearing flags on attachment: 263492 Committed r191304: <http://trac.webkit.org/changeset/191304>
WebKit Commit Bot
Comment 6 2015-10-19 12:12:30 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 7 2015-10-20 12:58:13 PDT
Still failing due to lack of newline at the end of file.. I'm not sure why this is happening. --- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/dynamic/insert-before-table-part-in-continuation-expected.txt +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/dynamic/insert-before-table-part-in-continuation-actual.txt @@ -204,4 +204,4 @@ RenderTableRow (anonymous) at (0,0) size 103x18 RenderTableCell (anonymous) at (0,0) size 103x18 [r=0 c=0 rs=1 cs=1] RenderText {#text} at (0,0) size 103x18 - text run at (0,0) width 103: "...continues here" \ No newline at end of file + text run at (0,0) width 103: "...continues here"
Ryan Haddad
Comment 8 2015-10-20 13:00:10 PDT
Created attachment 263603 [details] Patch New patch with newline at end of file
WebKit Commit Bot
Comment 9 2015-10-20 13:55:09 PDT
Comment on attachment 263603 [details] Patch Clearing flags on attachment: 263603 Committed r191356: <http://trac.webkit.org/changeset/191356>
WebKit Commit Bot
Comment 10 2015-10-20 13:55:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.