Bug 150120

Summary: Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore JavaScriptAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2015-10-14 05:11:24 PDT
Following on https://bugs.webkit.org/show_bug.cgi?id=149660, we might want to rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
Comment 1 youenn fablet 2015-10-14 09:17:39 PDT
Created attachment 263080 [details]
Patch
Comment 2 youenn fablet 2015-10-14 09:23:01 PDT
Comment on attachment 263080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263080&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:239
> +template<typename WrapperClass, typename DOMClass> inline JSDOMObject* createWrapper(JSDOMGlobalObject* globalObject, DOMClass* node)

We might want in the future to move from JSDOMObject to JSDOMWrapper<T>, make ScriptWrappable a template and so on.
Comment 3 WebKit Commit Bot 2015-10-14 12:19:12 PDT
Comment on attachment 263080 [details]
Patch

Clearing flags on attachment: 263080

Committed r191060: <http://trac.webkit.org/changeset/191060>
Comment 4 WebKit Commit Bot 2015-10-14 12:19:17 PDT
All reviewed patches have been landed.  Closing bug.