Bug 150120

Summary:

Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore JavaScript

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

youenn fablet

Reported 2015-10-14 05:11:24 PDT

Following on https://bugs.webkit.org/show_bug.cgi?id=149660, we might want to rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper

Attachments
Patch (57.31 KB, patch) 2015-10-14 09:17 PDT, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2015-10-14 09:17:39 PDT

Created attachment 263080 [details] Patch

youenn fablet

Comment 2 2015-10-14 09:23:01 PDT

Comment on attachment 263080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263080&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:239 > +template<typename WrapperClass, typename DOMClass> inline JSDOMObject* createWrapper(JSDOMGlobalObject* globalObject, DOMClass* node) We might want in the future to move from JSDOMObject to JSDOMWrapper<T>, make ScriptWrappable a template and so on.

WebKit Commit Bot

Comment 3 2015-10-14 12:19:12 PDT

Comment on attachment 263080 [details] Patch Clearing flags on attachment: 263080 Committed r191060: <http://trac.webkit.org/changeset/191060>

WebKit Commit Bot

Comment 4 2015-10-14 12:19:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.