Bug 150112

Summary: Use RefPtr<Image> return type for StyleImage::image()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+, commit-queue: commit-queue-

Simon Fraser (smfr)
Reported 2015-10-13 18:39:20 PDT
Use RefPtr<Image> return type for StyleImage::image()
Attachments
Patch (10.95 KB, patch)
2015-10-13 18:40 PDT, Simon Fraser (smfr) 		kling: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-10-13 18:40:03 PDT
Created attachment 263048 [details] Patch
Andreas Kling
Comment 2 2015-10-14 09:16:47 PDT
Comment on attachment 263048 [details] Patch Nice.
WebKit Commit Bot
Comment 3 2015-10-14 21:03:39 PDT
Comment on attachment 263048 [details] Patch Rejecting attachment 263048 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 263048, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: chedImageSet.cpp patching file Source/WebCore/rendering/style/StyleCachedImageSet.h patching file Source/WebCore/rendering/style/StyleGeneratedImage.cpp patching file Source/WebCore/rendering/style/StyleGeneratedImage.h patching file Source/WebCore/rendering/style/StyleImage.h patching file Source/WebCore/rendering/style/StylePendingImage.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/289229
Simon Fraser (smfr)
Comment 4 2015-10-14 21:56:04 PDT
https://trac.webkit.org/changeset/191083
Note You need to log in before you can comment on or make changes to this bug.