Bug 150112 - Use RefPtr<Image> return type for StyleImage::image()
Summary: Use RefPtr<Image> return type for StyleImage::image()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-13 18:39 PDT by Simon Fraser (smfr)
Modified: 2015-10-17 08:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.95 KB, patch)
2015-10-13 18:40 PDT, Simon Fraser (smfr) 		kling: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-10-13 18:39:20 PDT 
Use RefPtr<Image> return type for StyleImage::image()
Comment 1 Simon Fraser (smfr) 2015-10-13 18:40:03 PDT 
Created attachment 263048 [details]
Patch
Comment 2 Andreas Kling 2015-10-14 09:16:47 PDT 
Comment on attachment 263048 [details]
Patch

Nice.
Comment 3 WebKit Commit Bot 2015-10-14 21:03:39 PDT 
Comment on attachment 263048 [details]
Patch

Rejecting attachment 263048 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 263048, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
chedImageSet.cpp
patching file Source/WebCore/rendering/style/StyleCachedImageSet.h
patching file Source/WebCore/rendering/style/StyleGeneratedImage.cpp
patching file Source/WebCore/rendering/style/StyleGeneratedImage.h
patching file Source/WebCore/rendering/style/StyleImage.h
patching file Source/WebCore/rendering/style/StylePendingImage.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/289229
Comment 4 Simon Fraser (smfr) 2015-10-14 21:56:04 PDT 
https://trac.webkit.org/changeset/191083