Bug 150069

Summary: Add a Mac debug EWS queue
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, lforschler
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Alexey Proskuryakov
Reported 2015-10-12 17:47:34 PDT
Let's add a Mac debug EWS queue. And make it 32-bit to increase the coverage in this direction too.
Attachments
proposed patch (3.46 KB, patch)
2015-10-12 17:49 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (3.45 KB, patch)
2015-10-12 18:31 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (3.42 KB, patch)
2015-10-12 18:38 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-10-12 17:49:16 PDT
Created attachment 262947 [details] proposed patch I think that this should do it...
Alexey Proskuryakov
Comment 2 2015-10-12 18:31:45 PDT
Created attachment 262952 [details] proposed patch Now that I actually tried to run the tests, I realize that we can't test WK2, because modern WebKit API is 64-bit only.
Alexey Proskuryakov
Comment 3 2015-10-12 18:38:30 PDT
Created attachment 262954 [details] proposed patch But we can't enable tests in WK1 either - they run, but there are lots of slightly different results.
WebKit Commit Bot
Comment 4 2015-10-12 18:41:23 PDT
Attachment 262954 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/ews.json:43: Expecting property name enclosed in double quotes: line 43 column 5 (char 877) [json/syntax] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-10-12 19:04:09 PDT
Comment on attachment 262954 [details] proposed patch r=me
WebKit Commit Bot
Comment 6 2015-10-12 19:50:09 PDT
Comment on attachment 262954 [details] proposed patch Clearing flags on attachment: 262954 Committed r190922: <http://trac.webkit.org/changeset/190922>
WebKit Commit Bot
Comment 7 2015-10-12 19:50:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.