| Summary: | Add basic canvas tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
| Component: | Animations | Assignee: | Jon Lee <jonlee> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, rniwa, sabouhallawa, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 149053 | ||||||
| Attachments: |
|
||||||
|
Description
Jon Lee
2015-10-12 17:22:20 PDT
Created attachment 262945 [details]
Patch
Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review > PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 > + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2). Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review >> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 >> + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); > > You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2). maxSize is an int though... Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review >>> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 >>> + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); >> >> You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2). > > maxSize is an int though... Never mind. I thought maxSize is a rectangle of max width and max height and not a side in a square side. Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review > PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js:51 > +} > + > + > +function SimpleCanvasBenchmark(suite, test, options, recordTable, progressBar) { Nit: extra blank line Committed r190912: <http://trac.webkit.org/changeset/190912> |