Bug 150053

Summary: Refactor test suites to a separate class
Product: WebKit Reporter: Jon Lee <jonlee>
Component: AnimationsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, rniwa, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149053    
Attachments:
Description Flags
Patch none

Jon Lee
Reported 2015-10-12 15:17:07 PDT
Refactor test suites to a separate class
Attachments
Patch (10.47 KB, patch)
2015-10-12 15:20 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-12 15:17:39 PDT
<rdar://problem/23078645>
Jon Lee
Comment 2 2015-10-12 15:20:11 PDT
Created attachment 262927 [details] Patch
Dean Jackson
Comment 3 2015-10-12 15:33:08 PDT
Comment on attachment 262927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review > PerformanceTests/Animometer/runner/resources/animometer.js:120 > + var suiteDiv = document.createDocumentFragment(); Is there a reason you didn't create a "div"?
Said Abou-Hallawa
Comment 4 2015-10-12 15:51:53 PDT
Comment on attachment 262927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review > PerformanceTests/Animometer/runner/resources/animometer.js:67 > + enabledSuites.push(checkbox.suite); Is there a reason why we can not use enabledSuites.push(Suites[i])? > PerformanceTests/Animometer/runner/resources/animometer.js:125 > + checkbox.suite = suite; I am not sure about the cost of this assignment. Do we make a copy of the suite structure and assign it in the suite member of the checkbox variable? > PerformanceTests/ChangeLog:30 > + informal r=me
Jon Lee
Comment 5 2015-10-12 16:22:56 PDT
Committed r190902: <http://trac.webkit.org/changeset/190902>
Note You need to log in before you can comment on or make changes to this bug.