| Summary: | Refactor test suites to a separate class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
| Component: | Animations | Assignee: | Jon Lee <jonlee> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, rniwa, sabouhallawa, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Mac | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 149053 | ||||||
| Attachments: |
|
||||||
|
Description
Jon Lee
2015-10-12 15:17:07 PDT
Created attachment 262927 [details]
Patch
Comment on attachment 262927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review > PerformanceTests/Animometer/runner/resources/animometer.js:120 > + var suiteDiv = document.createDocumentFragment(); Is there a reason you didn't create a "div"? Comment on attachment 262927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review > PerformanceTests/Animometer/runner/resources/animometer.js:67 > + enabledSuites.push(checkbox.suite); Is there a reason why we can not use enabledSuites.push(Suites[i])? > PerformanceTests/Animometer/runner/resources/animometer.js:125 > + checkbox.suite = suite; I am not sure about the cost of this assignment. Do we make a copy of the suite structure and assign it in the suite member of the checkbox variable? > PerformanceTests/ChangeLog:30 > + informal r=me Committed r190902: <http://trac.webkit.org/changeset/190902> |