Bug 150051 – [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()

[Myles C. Maxfield]

Created attachment 262925 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 262925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:610
> +#if !PLATFORM(COCOA)
> +    if (run.length() > 1 && typesettingFeatures())
>          return Complex;
> +#endif

We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef?

[Myles C. Maxfield]

Comment on attachment 262925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review

>> Source/WebCore/platform/graphics/FontCascade.cpp:610
>> +#endif
> 
> We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef?

I think in this case, it would be worse. This thing is so simple that adding another function with two implementations is worse than this tiny ifdef.

[Myles C. Maxfield]

Committed r190895: <http://trac.webkit.org/changeset/190895>

[Radar WebKit Bug Importer]

<rdar://problem/23768511>