Bug 150045

Summary: Simplify WeakBlock visit and reap phases
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-10-12 13:36:52 PDT
Simplify WeakBlock visit and reap phases. In marking, WeakBlocks are visited last after MarkedBlocks have been visited. Likewise reaping happens after marking. In both cases, all MarkedBlocks should be either Marked or Retired. We shouldn't encounter any that are Allocated.
Attachments
[PATCH] Proposed Fix (3.12 KB, patch)
2015-10-12 13:39 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-10-12 13:39:27 PDT
Created attachment 262916 [details] [PATCH] Proposed Fix I've been running with this change without any problems.
Geoffrey Garen
Comment 2 2015-10-12 13:55:22 PDT
Comment on attachment 262916 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2015-10-13 17:10:44 PDT
Comment on attachment 262916 [details] [PATCH] Proposed Fix Clearing flags on attachment: 262916 Committed r191015: <http://trac.webkit.org/changeset/191015>
WebKit Commit Bot
Comment 4 2015-10-13 17:10:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.