Bug 150044

Summary: Web Inspector: Rebaseline Inspector generator tests and make better use of RWIProtocol constant
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-10-12 13:32:08 PDT
Rebaseline Inspector generator tests and make better use of RWIProtocol constant. 1. Tests were not rebaselined since the last changes to codegen. 2. The "RWIProtocol" OBJC_PREFIX can be used in more places instead of hard coding it.
Attachments
[PATCH] Proposed Fix (57.07 KB, patch)
2015-10-12 13:32 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-10-12 13:32:48 PDT
Created attachment 262915 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2015-10-12 13:33:54 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 3 2015-10-12 16:15:56 PDT
Comment on attachment 262915 [details] [PATCH] Proposed Fix oops... r=me
WebKit Commit Bot
Comment 4 2015-10-12 16:38:27 PDT
Comment on attachment 262915 [details] [PATCH] Proposed Fix Clearing flags on attachment: 262915 Committed r190905: <http://trac.webkit.org/changeset/190905>
WebKit Commit Bot
Comment 5 2015-10-12 16:38:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.