Bug 150044 - Web Inspector: Rebaseline Inspector generator tests and make better use of RWIProtocol constant
Summary: Web Inspector: Rebaseline Inspector generator tests and make better use of RW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-10-12 13:32 PDT by Joseph Pecoraro
Modified: 2015-10-12 16:38 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (57.07 KB, patch)
2015-10-12 13:32 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-12 13:32:08 PDT
Rebaseline Inspector generator tests and make better use of RWIProtocol constant.

1. Tests were not rebaselined since the last changes to codegen.
2. The "RWIProtocol" OBJC_PREFIX can be used in more places instead of hard coding it.
Comment 1 Joseph Pecoraro 2015-10-12 13:32:48 PDT
Created attachment 262915 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-12 13:33:54 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 BJ Burg 2015-10-12 16:15:56 PDT
Comment on attachment 262915 [details]
[PATCH] Proposed Fix

oops... r=me
Comment 4 WebKit Commit Bot 2015-10-12 16:38:27 PDT
Comment on attachment 262915 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 262915

Committed r190905: <http://trac.webkit.org/changeset/190905>
Comment 5 WebKit Commit Bot 2015-10-12 16:38:30 PDT
All reviewed patches have been landed.  Closing bug.