Summary: | PDFPlugin should take advantage of threaded scrolling | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, commit-queue, japhet, mitz, sam, simon.fraser | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Tim Horton
2015-10-12 11:12:50 PDT
Created attachment 262905 [details]
Patch
Created attachment 263543 [details]
Patch
Created attachment 264628 [details]
Patch
Attachment 264628 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1905: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1724: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:239: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 3 in 36 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264635 [details]
Patch
Attachment 264635 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1905: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1724: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:240: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 3 in 36 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264635&action=review > Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:536 > + m_accessibilityObject.get().pdfLayerController = m_pdfLayerController.get(); > + m_accessibilityObject.get().parent = webFrame()->page()->accessibilityRemoteObject(); .get(). :| > Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1423 > + } Weird that there's a fall-through here. I'd add a break; just to be sure. Same for all outer cases. > Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1749 > + PDFSelection *selectionForInitialSearch = [initialSelection copy]; Please use a RetainPtr here. > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:374 > + std::function<void(bool)> _completionHandler; void (bool). > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:882 > +// context.translate(0, -m_size.height()); What. |