| Summary: | [Curl] Increase limit of parallel network requests. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | peavo | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, galpeter | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
peavo
2015-10-12 11:03:13 PDT
Created attachment 262902 [details]
Patch
Comment on attachment 262902 [details]
Patch
What if the limit is too big? Why is there a limit?
(In reply to comment #2) > Comment on attachment 262902 [details] > Patch > > What if the limit is too big? Why is there a limit? Good point. It might be better to leave this decision to Curl, since it is probably handled well there. In that case, I dont't think a big limit would hurt :) It seems there already is a Curl option for this (with default 0, meaning infinite number of connections): http://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html Since Curl doesn't have a limit here, maybe we shouldn't either? If we limit the number of connections, I think the limit should be higher that it is now at least. Another problem with the limit is that it can effectively block all future network requests if the current connections are never closed (for some reason). Thanks for reviewing :) Comment on attachment 262902 [details] Patch Clearing flags on attachment: 262902 Committed r190887: <http://trac.webkit.org/changeset/190887> All reviewed patches have been landed. Closing bug. |