Summary: | [GTK][Mac] ICU-related build fixes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | WebKitGTK | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, darin, philip.chimento | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 126492 | ||||||||
Attachments: |
|
Description
Philippe Normand
2015-10-12 09:56:03 PDT
Created attachment 262894 [details]
Patch
Comment on attachment 262894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review > Source/JavaScriptCore/PlatformGTK.cmake:51 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Why is this specific to darwin? > Source/WTF/wtf/PlatformGTK.cmake:26 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Ditto. Comment on attachment 262894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review >> Source/JavaScriptCore/PlatformGTK.cmake:51 >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > Why is this specific to darwin? No idea. The wonders of CMake on Linux I suppose :) (In reply to comment #3) > Comment on attachment 262894 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262894&action=review > > >> Source/JavaScriptCore/PlatformGTK.cmake:51 > >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > > > Why is this specific to darwin? > > No idea. The wonders of CMake on Linux I suppose :) If that works for the other platforms, we could avoid conditionals that we don't even understand Created attachment 263679 [details]
patch
I’m just rubber stamping this; seems fine to me even though I’m not expert on how CMake works. Committed r191442: <http://trac.webkit.org/changeset/191442> |