Bug 150032

Summary: [GTK][Mac] ICU-related build fixes
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, darin, philip.chimento
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
Patch
none
patch darin: review+

Description Philippe Normand 2015-10-12 09:56:03 PDT 
I had some link errors and not-found-headers issues related with ICU on Mac.
Comment 1 Philippe Normand 2015-10-12 10:01:58 PDT 
Created attachment 262894 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-10-13 00:58:06 PDT 
Comment on attachment 262894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review

> Source/JavaScriptCore/PlatformGTK.cmake:51
> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")

Why is this specific to darwin?

> Source/WTF/wtf/PlatformGTK.cmake:26
> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")

Ditto.
Comment 3 Philippe Normand 2015-10-13 01:03:17 PDT 
Comment on attachment 262894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review

>> Source/JavaScriptCore/PlatformGTK.cmake:51
>> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
> 
> Why is this specific to darwin?

No idea. The wonders of CMake on Linux I suppose :)
Comment 4 Carlos Garcia Campos 2015-10-13 01:28:23 PDT 
(In reply to comment #3)
> Comment on attachment 262894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262894&action=review
> 
> >> Source/JavaScriptCore/PlatformGTK.cmake:51
> >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
> > 
> > Why is this specific to darwin?
> 
> No idea. The wonders of CMake on Linux I suppose :)

If that works for the other platforms, we could avoid conditionals that we don't even understand
Comment 5 Philippe Normand 2015-10-21 08:22:49 PDT 
Created attachment 263679 [details]
patch
Comment 6 Darin Adler 2015-10-21 08:50:45 PDT 
I’m just rubber stamping this; seems fine to me even though I’m not expert on how CMake works.
Comment 7 Philippe Normand 2015-10-22 00:08:45 PDT 
Committed r191442: <http://trac.webkit.org/changeset/191442>