Summary: | Web Inspector: Improve error messages for internal Inspector code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Created attachment 262819 [details]
Patch
Created attachment 262820 [details]
Patch
Note that on the screenshot the following stack trace items appear twice: dispatch — InspectorBackend.js:89 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 The first one comes from the logged exception (black text) and the second one comes from console.error (red text). We could have used console.warn to not append the second one, but it wouldn't look like error anymore. Comment on attachment 262820 [details] Patch Clearing flags on attachment: 262820 Committed r190839: <http://trac.webkit.org/changeset/190839> All reviewed patches have been landed. Closing bug. |
Created attachment 262818 [details] [Image] Before/After See the screenshot.