Bug 149995

Summary: Web Inspector: Improve error messages for internal Inspector code
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Before/After
none
Patch
none
Patch none

Nikita Vasilyev
Reported 2015-10-09 21:29:00 PDT
Created attachment 262818 [details] [Image] Before/After See the screenshot.
Attachments
[Image] Before/After (445.78 KB, image/png)
2015-10-09 21:29 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.11 KB, patch)
2015-10-09 21:32 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2015-10-09 21:33 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-09 21:29:23 PDT
<rdar://problem/23059365>
Nikita Vasilyev
Comment 2 2015-10-09 21:32:11 PDT
Created attachment 262819 [details] Patch
Nikita Vasilyev
Comment 3 2015-10-09 21:33:20 PDT
Created attachment 262820 [details] Patch
Nikita Vasilyev
Comment 4 2015-10-09 21:41:09 PDT
Note that on the screenshot the following stack trace items appear twice: dispatch — InspectorBackend.js:89 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 The first one comes from the logged exception (black text) and the second one comes from console.error (red text). We could have used console.warn to not append the second one, but it wouldn't look like error anymore.
WebKit Commit Bot
Comment 5 2015-10-10 08:51:06 PDT
Comment on attachment 262820 [details] Patch Clearing flags on attachment: 262820 Committed r190839: <http://trac.webkit.org/changeset/190839>
WebKit Commit Bot
Comment 6 2015-10-10 08:51:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.