Bug 149994

Summary: Perf dashboard tools shouldn't require server credentials in multiple configuration files
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, jake.nielsen.webkit, jond, lforschler, rniwa, slewis, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+, cdumez: commit-queue-

Ryosuke Niwa
Reported 2015-10-09 20:26:54 PDT
Right now, change detection script's configurations, subversion configurations, and the dashboard access configurations each require username/password. Consolidate all those into one JSON at most.
Attachments
Patch (11.90 KB, patch)
2015-10-09 21:26 PDT, Ryosuke Niwa 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-10-09 21:26:17 PDT
Created attachment 262817 [details] Patch
Chris Dumez
Comment 2 2015-10-12 15:41:29 PDT
Comment on attachment 262817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262817&action=review r=me with comments. > Websites/perf.webkit.org/ChangeLog:3 > + Perf dashboard tools shouldn't require sever credentials in multiple configuration files s/sever/server > Websites/perf.webkit.org/tools/detect-changes.js:31 > + for (var i = 0; i < args.length; i+=2) { missing spaces around += > Websites/perf.webkit.org/tools/detect-changes.js:42 > + console.error('Invalid arguemnt:', current); typo: argument.
Ryosuke Niwa
Comment 3 2015-10-12 16:06:14 PDT
Committed r190900: <http://trac.webkit.org/changeset/190900>
Note You need to log in before you can comment on or make changes to this bug.