Bug 149961

Summary: No need to keep setting needsVisit flag in SmallStrings
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ggaren
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-10-09 11:45:35 PDT
No need to keep setting needsVisit flag in SmallStrings.

The strings are all setup before GC is enabled by the VM, and all in private functions. No need to keep updating the flag if it couldn't have changed.
Comment 1 Joseph Pecoraro 2015-10-09 11:47:26 PDT
Created attachment 262782 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-09 16:18:33 PDT
Comment on attachment 262782 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 262782

Committed r190829: <http://trac.webkit.org/changeset/190829>
Comment 3 WebKit Commit Bot 2015-10-09 16:18:36 PDT
All reviewed patches have been landed.  Closing bug.