Bug 149960

Summary:

[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2015-10-09 10:49:54 PDT

[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext

Comment 1 Simon Fraser (smfr) 2015-10-09 10:50:22 PDT

Created attachment 262780 [details]
Patch

Comment 2 WebKit Commit Bot 2015-10-09 14:35:29 PDT

Comment on attachment 262780 [details]
Patch

Clearing flags on attachment: 262780

Committed r190819: <http://trac.webkit.org/changeset/190819>

Comment 3 WebKit Commit Bot 2015-10-09 14:35:32 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Darin Adler 2015-10-13 12:10:14 PDT

Comment on attachment 262780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262780&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:81
> +    self.willBeginZoomingCallback = nil;
> +    self.didEndZoomingCallback = nil;
> +    self.didShowKeyboardCallback = nil;
> +    self.didHideKeyboardCallback = nil;
> +
> +    self.zoomToScaleCompletionHandler = nil;
> +    self.showKeyboardCompletionHandler = nil;

I think the best practice is to call release, not call the setter method.