Summary: | WKWebView needs SPI to customize immediate actions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, bdakin, commit-queue, mitz, sam, thorton | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Beth Dakin
2015-10-08 16:29:17 PDT
Created attachment 262746 [details]
Patch
Attachment 262746 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:825: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
ERROR: Source/WebKit2/Shared/WebHitTestResultData.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/Shared/API/APIHitTestResult.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.h:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:73: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:58: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1156: The parameter name "hitTestResultData" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1158: The parameter name "hitTestResultData" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 10 in 39 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 262750 [details]
Patch
Trying to fix these red bots.
Attachment 262750 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 262779 [details]
Patch
Attachment 262779 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 262796 [details]
Patch
Attachment 262796 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 48 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thank you!!!! http://trac.webkit.org/changeset/190823 |