Bug 149939

Summary:

WKWebView needs SPI to customize immediate actions

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, commit-queue, mitz, sam, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	andersca: review+

Beth Dakin

Reported 2015-10-08 16:29:17 PDT

WKWebView needs SPI to customize immediate actions rdar://problem/20016849

Attachments
Patch (134.31 KB, patch) 2015-10-08 22:05 PDT, Beth Dakin	no flags	Details Formatted Diff Diff
Patch (143.21 KB, patch) 2015-10-08 22:53 PDT, Beth Dakin	no flags	Details Formatted Diff Diff
Patch (143.04 KB, patch) 2015-10-09 10:50 PDT, Beth Dakin	no flags	Details Formatted Diff Diff
Patch (143.09 KB, patch) 2015-10-09 14:56 PDT, Beth Dakin	andersca: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2015-10-08 22:05:35 PDT

Created attachment 262746 [details] Patch

WebKit Commit Bot

Comment 2 2015-10-08 22:09:04 PDT

Attachment 262746 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:825: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit2/Shared/WebHitTestResultData.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/APIHitTestResult.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:73: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1156: The parameter name "hitTestResultData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1158: The parameter name "hitTestResultData" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 10 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 3 2015-10-08 22:53:34 PDT

Created attachment 262750 [details] Patch Trying to fix these red bots.

WebKit Commit Bot

Comment 4 2015-10-08 22:55:33 PDT

Attachment 262750 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 5 2015-10-09 10:50:09 PDT

Created attachment 262779 [details] Patch

WebKit Commit Bot

Comment 6 2015-10-09 10:53:31 PDT

Attachment 262779 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 7 2015-10-09 14:56:18 PDT

Created attachment 262796 [details] Patch

WebKit Commit Bot

Comment 8 2015-10-09 14:59:42 PDT

Attachment 262796 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 9 2015-10-09 15:25:39 PDT

Thank you!!!! http://trac.webkit.org/changeset/190823

Beth Dakin

Comment 10 2015-10-09 16:20:25 PDT

Build fixes: http://trac.webkit.org/changeset/190828 http://trac.webkit.org/changeset/190830

Note You need to log in before you can comment on or make changes to this bug.