Bug 149920

Summary:

[GTK] Stop using a nested main loop for popup menus

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, svillar

Priority:

Keywords:

Gtk

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	svillar: review+

Description Carlos Garcia Campos 2015-10-08 02:46:39 PDT

WebPageProxy used to expect the popup menus to run in a nested main loop and invalidated the object right after showing it. But this is nor longer the case, so there's no reason to keep using the nested main loop.

Comment 1 Carlos Garcia Campos 2015-10-08 02:51:32 PDT

Created attachment 262683 [details]
Patch

Comment 2 Sergio Villar Senin 2015-10-08 03:03:26 PDT

Comment on attachment 262683 [details]
Patch

let's nuke them all!

Comment 3 Carlos Garcia Campos 2015-10-08 03:07:21 PDT

Committed r190717: <http://trac.webkit.org/changeset/190717>