Bug 149920

Summary: [GTK] Stop using a nested main loop for popup menus
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, svillar
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2015-10-08 02:46:39 PDT
WebPageProxy used to expect the popup menus to run in a nested main loop and invalidated the object right after showing it. But this is nor longer the case, so there's no reason to keep using the nested main loop.
Attachments
Patch (8.60 KB, patch)
2015-10-08 02:51 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-10-08 02:51:32 PDT
Created attachment 262683 [details] Patch
Sergio Villar Senin
Comment 2 2015-10-08 03:03:26 PDT
Comment on attachment 262683 [details] Patch let's nuke them all!
Carlos Garcia Campos
Comment 3 2015-10-08 03:07:21 PDT
Committed r190717: <http://trac.webkit.org/changeset/190717>
Note You need to log in before you can comment on or make changes to this bug.